Ethereal-dev: Re: [Ethereal-dev] Getting rid of ui_util.h mess?

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Joerg Mayer <jmayer@xxxxxxxxx>
Date: Sat, 20 Aug 2005 14:06:21 +0200
On Sat, Aug 20, 2005 at 01:15:31PM +0200, Ulf Lamping wrote:
> The intend (I think) is to keep the UI dependant parts out of the / dir.

Why? There are 5 files in the top level dir that include ui_util.h. Either
they have to know about the gtk specific stuff or not. If they should not
include stuff from the gtk/ dir, maybe they should be moved into the gtk/
dir?

> *  @todo Move these window functions to a new file win_utils.h?

If we really want to keep that concept, then yes, something like that.
And that file should be included in all the files in gtk/ that implement
one of the functions declared in that file to ensure consistent declarations.
Maybe gtk_utils.h would be a better name.

> I'll make some changes to fix this, please be patient :-)

OK, I'll add some comments to ui_util.h as to which functions are implemented
in which file and leave it alone by now (either until we decide to remove it
after all or implement your solution or a third one).

 Ciao
       Joerg
-- 
Joerg Mayer                                           <jmayer@xxxxxxxxx>
We are stuck with technology when what we really want is just stuff that
works. Some say that should read Microsoft instead of technology.