Ethereal-dev: Re: [Ethereal-dev] Getting rid of ui_util.h mess?

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Ulf Lamping <ulf.lamping@xxxxxx>
Date: Sat, 20 Aug 2005 13:15:31 +0200
Joerg Mayer wrote:


While looking at the "no previous declaration" warnings in gtk/ I was
reminded again about the (top-level) ui_util.h file. I think it should go
and be replaced by the proper includes from gtk/. 
The intend (I think) is to keep the UI dependant parts out of the / dir.


Here is why:
- We have a file of the same name in gtk/ but different contents. This
 makes things confusing. So confusing that there is a comment about this
 in at least one place.

I agree, that should really be changed.

You mean:

*  @todo Move these window functions to a new file win_utils.h?

That's meant to move *some* parts of the file to a new one.


- The prototypes given in that file are not validated automatically to
 match the prototypes in gtk/*.c

Well, an automatic validation is a good idea. :-)


- It creates "no previous declaration" warnings because they have non-static
 functions that are not declared in any (included) .h file.
Is there any real reason for its continued existence?

For it's existence, I would think yes.

For it's name, no.

I'll make some changes to fix this, please be patient :-)

Regards, ULFL