Ethereal-dev: Re: [Ethereal-dev] Patch to packet SIP to make content type lower case, Patch to

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: "Olivier Biot" <ethereal@xxxxxxxxxx>
Date: Tue, 20 Jan 2004 00:10:38 +0100
From: "Lars Roland"
|

| Hello all,
|
| Anders Broman (TN/EAB) wrote:
| > Hi,
| > Just to clearify the intent:
| >
| > Currently the SDP dissector adds /SDP in the protocoll column e.g
| > a MEGACO message with SDP descriptions would show up as
| > MEGACO/SDP in the protocol column, this sort of make sense as SDP
just decodes
| > a part of the MEGACO message "written in SDP" the same is true for
SIP and BICC.
| >  I was thinking that if there was a SIP message with ISUP ( and
SDP ) parts included in it
| > it would make sense to show it as SIP/ISUP/SDP as the "main"
message still is SIP or perhaps only "SIP" ?
| >
| > Currently the message will show "application/ISUP/SDP" ( as SIP is
owerwritten )at least it should be changed
| > to "ISUP/SDP" or "ISUP(ITU)/SDP" in my opinion.
| >
| > Comments wellcome.
| >
|
| I agree. Subdissectors should not overwrite "SIP" in the protocol
| column. However I would set the protocol column to "SIP-T" and not
to
| "SIP/ISUP", but both solutions are OK.

So tell me what I have to do here :)

| BTW, last patch to packet-sip.c introduced a bug. Patch is attached.

The SIP patch has been checked in.

Regards,

Olivier