Ethereal-dev: Re: [Ethereal-dev] SMPP: Multiple PDU's within one TCP packet

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: "Olivier Biot" <ethereal@xxxxxxxxxx>
Date: Tue, 20 Jan 2004 00:18:08 +0100
From: "Chris Wilson"


| On Sun, 18 Jan 2004 04:42:49 -0800
| Guy Harris wrote:
|
| > On Sun, Jan 18, 2004 at 12:16:23PM +0000, Chris Wilson wrote:
| > > Ok - I'll make things work that way.
| >
| > Note that if you make it use "tcp_dissect_pdus()" you'll get that
for
| > free.
|
| Yep, it's great :)
|
| Lets have another go then, this is much nicer... Attached is a patch
to packet-smpp.c (version 1.25 - that's before Olivier's last commit).
It uses tcp_dissect_pdus() if it's running on TCP (it checks that
pinfo->ptype==PT_TCP - which I hope is sensible!).

This looks fine to me. However I'll need to backport my previous patch
:) Expect a merger of both patches tomorrow as I'm tight on timing
right now (I hope we're not releasing a new Ethereal version tomorrow
:)

| Olivier: Shall I also go ahead and separate the GSM SMS User Data
dissector from the SMPP dissector so that it can be used by other
dissectors?

Go ahead! I don't know if we really need to add it to another file
(you can define more than one protocol dissector per file; see for
example the message/http media type in HTTP and the
application/vnd.wap.sia media type in WSP), but I don't have any
objections :)

Regards,

Olivier