Ethereal-dev: Re: [Ethereal-dev] Patch to packet SIP to make content type lower case, Patch to
Hello all,
Anders Broman (TN/EAB) wrote:
Hi,
Just to clearify the intent:
Currently the SDP dissector adds /SDP in the protocoll column e.g
a MEGACO message with SDP descriptions would show up as
MEGACO/SDP in the protocol column, this sort of make sense as SDP just decodes
a part of the MEGACO message "written in SDP" the same is true for SIP and BICC.
I was thinking that if there was a SIP message with ISUP ( and SDP ) parts included in it
it would make sense to show it as SIP/ISUP/SDP as the "main" message still is SIP or perhaps only "SIP" ?
Currently the message will show "application/ISUP/SDP" ( as SIP is owerwritten )at least it should be changed
to "ISUP/SDP" or "ISUP(ITU)/SDP" in my opinion.
Comments wellcome.
I agree. Subdissectors should not overwrite "SIP" in the protocol
column. However I would set the protocol column to "SIP-T" and not to
"SIP/ISUP", but both solutions are OK.
BTW, last patch to packet-sip.c introduced a bug. Patch is attached.
Regards,
Lars
Index: ethereal/packet-sip.c
===================================================================
RCS file: /cvsroot/ethereal/packet-sip.c,v
retrieving revision 1.55
diff -u -r1.55 packet-sip.c
--- ethereal/packet-sip.c 18 Jan 2004 23:21:20 -0000 1.55
+++ ethereal/packet-sip.c 19 Jan 2004 11:22:49 -0000
@@ -708,7 +708,6 @@
#else
media_type_str_lower_case = g_ascii_strdown(media_type_str, -1);
#endif
- g_free(media_type_str);
break;
case POS_CONTACT :
