Ethereal-dev: Re: [Ethereal-dev] Small ntp fix

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: Joerg Mayer <jmayer@xxxxxxxxx>
Date: Mon, 9 Apr 2001 17:39:38 +0200
Moin,

this is an update to my previous mail as I found another typo. Something I
just noted: These patches are versus some 0.8.15cvs, not the current cvs.
If these things were fixed already, please ignore :-)

  Ciao
     Jörg

On Mon, Apr 09, 2001 at 04:22:07PM +0200, Joerg Mayer wrote:
> get_hostname expects its argument in network order. I don't really like
> to convert forward and backward again on LE machines but didn't find a
> better solution.

-- 
Joerg Mayer                                          <jmayer@xxxxxxxxx>
I found out that "pro" means "instead of" (as in proconsul). Now I know
what proactive means.
Changelog: <jmayer@xxxxxxxxx>
    packet-ntp.c
	- get_hostname expects the ip address in network order
	- Fix Typo (Pooling -> Polling)


--- packet-ntp.c.distrib	Mon Apr  9 15:31:29 2001
+++ packet-ntp.c	Mon Apr  9 17:06:05 2001
@@ -315,8 +315,8 @@
 		proto_tree_add_uint_format(ntp_tree, hf_ntp_ppoll, tvb, 2, 1,
 					   ppoll,
 					   (((ppoll >= 4) && (ppoll <= 16)) ? 
-					   "Peer Pooling Interval: %u (%u sec)" :
-					   "Peer Pooling Interval: invalid (%u)"),
+					   "Peer Polling Interval: %u (%u sec)" :
+					   "Peer Polling Interval: invalid (%u)"),
 					   ppoll,
 					   1 << ppoll);
 
@@ -372,7 +372,7 @@
 			}
 		} else {
 			buff[sizeof(buff) - 1] = '\0';
-			strncpy (buff, get_hostname (tvb_get_ntohl(tvb, 12)),
+			strncpy (buff, get_hostname (htonl(tvb_get_ntohl(tvb, 12))),
 			    sizeof(buff));
 			if (buff[sizeof(buff) - 1] != '\0')
 				strcpy(&buff[sizeof(buff) - 4], "...");