Ethereal-dev: Re: [Ethereal-dev] Small ntp fix

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Guy Harris <guy@xxxxxxxxxx>
Date: Mon, 9 Apr 2001 14:45:18 -0700 (PDT)
> this is an update to my previous mail as I found another typo. Something I
> just noted: These patches are versus some 0.8.15cvs, not the current cvs.

Checked in.

> On Mon, Apr 09, 2001 at 04:22:07PM +0200, Joerg Mayer wrote:
> > get_hostname expects its argument in network order. I don't really like
> > to convert forward and backward again on LE machines but didn't find a
> > better solution.

In some other dissectors, it does a "memcpy()" (for old-style
dissectors) or a "tvb_memcpy()" (for new-style dissectors) to copy the 4
bytes of IP address to a "guint".

"get_hostname6()" takes a pointer to an IPv6 address; I guess we could
make "get_hostname()" take a pointer to an IPv4 address, and we could
pass it the result of "tvb_get_ptr(tvb, offset, 4)" (which would mean
its argument would *not* be a "guint *", as the result of
"tvb_get_ptr()" is not guaranteed to be aligned on any particular
boundary in memory).