On Wed, Jan 17, 2018 at 2:05 AM, Gerald Combs <gerald@xxxxxxxxxxxxx> wrote:
> On 1/13/18 4:16 AM, Stig Bjørlykke wrote:
>> - Qt: Missing string translations after source code was moved to
>> utils/models/manager/widgets subdirectories
>
> Do you know what's missing? This shouldn't be too hard to fix.
I haven't investigated this, but I'm thinking that the generation of
the *.ts files should also include the source subdirectories. The
translations was lost just after the move to separate directories.
>> - ByteView: Hovering bytes does not highlight the field as it used to do
>> - ByteView: Vertical white and horisontal black lines issues
>> - ByteView: Color issue when clicking a byte multiple times
>
> The 2.4 byte view didn't distinguish between hovered and a locked bytes.
> I initially tried to do so by drawing an overline+undlerline over hovered bytes
> and coloring locked bytes. Change 25348 draws a full outline instead of an
> overline+undlerline.
The change makes this issues better. I'm still not sure about the
"blue text on yellow background" when locked, this does not look so
good with the macOS colour schemes. Maybe this could be changed to a
red thicker outline? Or maybe use our "marked packet" colours? Or a
combination.
I never understood the white vertical lines, but now it seems like
it's a bug when drawing the background colour. Have a look at the
attached picture.
When locking a byte the first time all bytes within a protocol has
grey background colour but this grey background colour is not added on
subsequent locks within the same protocol byte range.
And selecting a byte does not expand the corresponding tree item as it
does in 2.4.
--
Stig Bjørlykke
Attachment:
Screen Shot 2018-01-17 at 20.35.51.png
Description: PNG image
