Wireshark-dev: Re: [Wireshark-dev] 2.5.0 release on January 16
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Gerald Combs <gerald@xxxxxxxxxxxxx>
Date: Tue, 16 Jan 2018 17:05:02 -0800
On 1/13/18 4:16 AM, Stig Bjørlykke wrote:
> We still have some regression issues after 2.5 refactoring which
> should be fixed.
> Does anyone work on this?
> 
> 
> Qt/UI regression issues after refactoring:
> - Qt: Missing string translations after source code was moved to
> utils/models/manager/widgets subdirectories
> - Qt: Plurality does not work for strings in utils/models/manager/widgets files

Do you know what's missing? This shouldn't be too hard to fix.

> - PacketList: Markers in "Number" columns are gone
> - PacketDetails: Only top-level node-expansion is remembered when
> switching between packets
> - PacketDetails: Link colours in links are gone

The last couple of updates to proto_tree.cpp should fix these.

> - ByteView: Wrong font size on startup and profile change (if using
> other size than default)

Not sure what's causing this.

> - ByteView: Hovering bytes does not highlight the field as it used to do
> - ByteView: Vertical white and horisontal black lines issues
> - ByteView: Color issue when clicking a byte multiple times

The 2.4 byte view didn't distinguish between hovered and a locked bytes. I initially tried to do so by drawing an overline+undlerline over hovered bytes and coloring locked bytes. Change 25348 draws a full outline instead of an overline+undlerline.