Wireshark-dev: Re: [Wireshark-dev] Problem while compiling wireshark master
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Remy Leone <remy.leone@xxxxxxxx>
Date: Tue, 4 Jul 2017 15:35:18 +0200
I've tried with libnl but it still doesn't work:

        "Unable to open ./.svn/entries",
        "ar: `u' modifier ignored since `D' is the default (see `U')",
        "ar: `u' modifier ignored since `D' is the default (see `U')",
        "ascend_scanner.c: In function 'yy_get_next_buffer':",
        "ascend_scanner.c:2502:47: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]",
        "  if ((int) (yyg->yy_n_chars + number_to_move) > YY_CURRENT_BUFFER_LVALUE->yy_buf_size) {",
        "                                               ^",
        "k12text.c: In function 'yy_get_next_buffer':",
        "k12text.c:1711:47: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]",
        "  if ((int) (yyg->yy_n_chars + number_to_move) > YY_CURRENT_BUFFER_LVALUE->yy_buf_size) {",
        "                                               ^",
        "ar: `u' modifier ignored since `D' is the default (see `U')",
        "ar: `u' modifier ignored since `D' is the default (see `U')",
        "ar: `u' modifier ignored since `D' is the default (see `U')",
        "ar: `u' modifier ignored since `D' is the default (see `U')",
        "scanner.c: In function 'yy_get_next_buffer':",
        "scanner.c:1703:47: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]",
        "  if ((int) (yyg->yy_n_chars + number_to_move) > YY_CURRENT_BUFFER_LVALUE->yy_buf_size) {",
        "                                               ^",
        "ar: `u' modifier ignored since `D' is the default (see `U')",
        "ar: `u' modifier ignored since `D' is the default (see `U')",
        "ar: `u' modifier ignored since `D' is the default (see `U')",
        "ar: `u' modifier ignored since `D' is the default (see `U')",
        "ar: `u' modifier ignored since `D' is the default (see `U')",
        "ar: `u' modifier ignored since `D' is the default (see `U')",
        "ar: `u' modifier ignored since `D' is the default (see `U')",
        "diam_dict.c: In function 'yy_get_next_buffer':",
        "diam_dict.c:2330:47: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]",
        "  if ((int) (yyg->yy_n_chars + number_to_move) > YY_CURRENT_BUFFER_LVALUE->yy_buf_size) {",
        "                                               ^",
        "dtd_parse.c: In function 'yy_get_next_buffer':",
        "dtd_parse.c:1681:47: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]",
        "  if ((int) (yyg->yy_n_chars + number_to_move) > YY_CURRENT_BUFFER_LVALUE->yy_buf_size) {",
        "                                               ^",
        "dtd_preparse.c: In function 'yy_get_next_buffer':",
        "dtd_preparse.c:1368:47: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]",
        "  if ((int) (yyg->yy_n_chars + number_to_move) > YY_CURRENT_BUFFER_LVALUE->yy_buf_size) {",
        "                                               ^",
        "radius_dict.c: In function 'yy_get_next_buffer':",
        "radius_dict.c:2131:47: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]",
        "  if ((int) (yyg->yy_n_chars + number_to_move) > YY_CURRENT_BUFFER_LVALUE->yy_buf_size) {",
        "                                               ^",
        "uat_load.c: In function 'yy_get_next_buffer':",
        "uat_load.c:1458:47: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]",
        "  if ((int) (yyg->yy_n_chars + number_to_move) > YY_CURRENT_BUFFER_LVALUE->yy_buf_size) {",
        "                                               ^",
        "ar: `u' modifier ignored since `D' is the default (see `U')",
        "ar: `u' modifier ignored since `D' is the default (see `U')",
        "ar: `u' modifier ignored since `D' is the default (see `U')",
        "In file included from iface_monitor.c:55:0:",
        "/_usr/include/net/if.h:129:0: error: \"IFNAMSIZ\" redefined [-Werror]",
        " # define IFNAMSIZ IF_NAMESIZE",
        " ^",
        "In file included from /usr/include/libnl3/netlink/netlink.h:24:0,",
        "                 from /usr/include/libnl3/netlink/msg.h:15,",
        "                 from iface_monitor.c:40:",
        "/usr/include/libnl3/netlink/netlink-compat.h:21:0: note: this is the location of the previous definition",
        " #define IFNAMSIZ 16",
        " ^",
        "cc1: all warnings being treated as errors",
        "make[2]: *** [libcaputils_a-iface_monitor.o] Error 1",
        "make[2]: *** Waiting for unfinished jobs....",
        "make[1]: *** [all-recursive] Error 1",
        "make: *** [all] Error 2"


2017-07-04 14:55 GMT+02:00 Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>:


On Tue, Jul 4, 2017 at 2:19 PM, Pascal Quantin <pascal.quantin@xxxxxxxxx> wrote:
Guy, do you remember because of which libnl version you moved net/if.h inclusion after libnl ones in 592a0fcf04c3f7f9f23476525877763303a1a87d?
Should we include net/if.h first when compiling with libnl3 to cope with this (newly introduced?) redefinition?
 Do not coming from missing some nl lib with tshark? (on debian/ubuntu packages)
https://packages.ubuntu.com/trusty/wireshark
https://packages.ubuntu.com/trusty/tshark



Pascal.


2017-07-04 14:06 GMT+02:00 Remy Leone <remy.leone@xxxxxxxx>:
I get similar problems with Ubuntu:

        "Unable to open /tmp/wireshark-master/.svn/entries",
        "/tmp/wireshark-master/wiretap/ascend_scanner.c: In function 'yy_get_next_buffer':",
        "/tmp/wireshark-master/wiretap/ascend_scanner.c:2502:47: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]",
        "  if ((int) (yyg->yy_n_chars + number_to_move) > YY_CURRENT_BUFFER_LVALUE->yy_buf_size) {",
        "                                               ^",
        "k12text.c: In function 'yy_get_next_buffer':",
        "k12text.c:1711:47: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]",
        "  if ((int) (yyg->yy_n_chars + number_to_move) > YY_CURRENT_BUFFER_LVALUE->yy_buf_size) {",
        "                                               ^",
        "In file included from /tmp/wireshark-master/caputils/iface_monitor.c:55:0:",
        "/_usr/include/net/if.h:129:0: error: \"IFNAMSIZ\" redefined [-Werror]",
        " # define IFNAMSIZ IF_NAMESIZE",
        " ^",
        "In file included from /usr/include/libnl3/netlink/netlink.h:24:0,",
        "                 from /usr/include/libnl3/netlink/msg.h:15,",
        "                 from /tmp/wireshark-master/caputils/iface_monitor.c:40:",
        "/usr/include/libnl3/netlink/netlink-compat.h:21:0: note: this is the location of the previous definition",
        " #define IFNAMSIZ 16",
        " ^",
        "cc1: all warnings being treated as errors",
        "make[2]: *** [caputils/CMakeFiles/caputils.dir/iface_monitor.c.o] Error 1",
        "make[1]: *** [caputils/CMakeFiles/caputils.dir/all] Error 2",
        "make[1]: *** Waiting for unfinished jobs....",
        "make: *** [all] Error 2"


2017-07-04 13:46 GMT+02:00 Remy Leone <remy.leone@xxxxxxxx>:
I'm not sure. Maybe it's only related to the debian stable version. I'm going to see if it also fails on a ubuntu 16.04.
A solution to test that would be to add the last debian stable version to buildbot. Would that be complicated to set up? 

2017-07-04 13:39 GMT+02:00 Pascal Quantin <pascal.quantin@xxxxxxxxx>:


2017-07-04 13:37 GMT+02:00 Pascal Quantin <pascal.quantin@xxxxxxxxx>:
Hi Remy,

2017-07-04 13:13 GMT+02:00 Remy Leone <remy.leone@xxxxxxxx>:
Hello,

I stumble upon this error in wireshark master. I use debian stretch with system packages installed from the apt-get build-dep tshark. Does it sound familiar?

        "/tmp/wireshark-master/epan/dissectors/packet-parlay.c:5381:27: warning: 'org_csapi_policy_TpPolicyConditionListType' defined but not used [-Wunused-const-variable=]",
        " static const value_string org_csapi_policy_TpPolicyConditionListType[] = {",
        "                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~",
        "/tmp/wireshark-master/epan/dissectors/packet-parlay.c:4151:27: warning: 'org_csapi_fw_TpLoadStatusError' defined but not used [-Wunused-const-variable=]",
        " static const value_string org_csapi_fw_TpLoadStatusError[] = {",
        "                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~",
        "/tmp/wireshark-master/epan/dissectors/packet-parlay.c:4084:27: warning: 'org_csapi_fw_TpFWExceptionType' defined but not used [-Wunused-const-variable=]",
        " static const value_string org_csapi_fw_TpFWExceptionType[] = {",
        "                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~",
        "/tmp/wireshark-master/epan/dissectors/packet-parlay.c:4041:27: warning: 'org_csapi_fw_TpAPIUnavailReason' defined but not used [-Wunused-const-variable=]",
        " static const value_string org_csapi_fw_TpAPIUnavailReason[] = {",
        "                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~",
        "Unable to open /tmp/wireshark-master/.svn/entries",
        "In file included from /tmp/wireshark-master/caputils/iface_monitor.c:55:0:",
        "/_usr/include/net/if.h:129:0: error: \"IFNAMSIZ\" redefined [-Werror]",
        " # define IFNAMSIZ IF_NAMESIZE",
        " ",
        "In file included from /usr/include/libnl3/netlink/netlink.h:24:0,",
        "                 from /usr/include/libnl3/netlink/msg.h:15,",
        "                 from /tmp/wireshark-master/caputils/iface_monitor.c:40:",
        "/usr/include/libnl3/netlink/netlink-compat.h:21:0: note: this is the location of the previous definition",
        " #define IFNAMSIZ 16",
        " ",
        "cc1: all warnings being treated as errors",
        "make[2]: *** [caputils/CMakeFiles/caputils.dir/iface_monitor.c.o] Error 1",
        "make[1]: *** [caputils/CMakeFiles/caputils.dir/all] Error 2",
        "make[1]: *** Waiting for unfinished jobs....",
        "make: *** [all] Error 2"

It looks like iface_monitor.c should be modified so as to include net/if.h before netlink/msg.h. Could you give it a try?

That said the comments in the file suggest that net/if.h needs to be included after libnl include (at least for some versions). But netlink-compat.h defines IFNAMESIZ only if it not defined yet... Another chicken and egg situation?


Pascal.


___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request@wireshark.org?subject=unsubscribe



___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request@wireshark.org?subject=unsubscribe


___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request@wireshark.org?subject=unsubscribe


___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request@wireshark.org?subject=unsubscribe