Wireshark · Wireshark-dev: Re: [Wireshark-dev] Problem while compiling wireshark master

[Pascal Quantin <pascal.quantin@xxxxxxxxx>]

2017-07-04 13:37 GMT+02:00 Pascal Quantin <pascal.quantin@xxxxxxxxx>:

Hi Remy,

2017-07-04 13:13 GMT+02:00 Remy Leone <remy.leone@xxxxxxxx>:

Hello,

I stumble upon this error in wireshark master. I use debian stretch with system packages installed from the apt-get build-dep tshark. Does it sound familiar?

        "/tmp/wireshark-master/epan/dissectors/packet-parlay.c:5381:27: warning: 'org_csapi_policy_TpPolicyConditionListType' defined but not used [-Wunused-const-variable=]",

        " static const value_string org_csapi_policy_TpPolicyConditionListType[] = {",

        "                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~",

        "/tmp/wireshark-master/epan/dissectors/packet-parlay.c:4151:27: warning: 'org_csapi_fw_TpLoadStatusError' defined but not used [-Wunused-const-variable=]",

        " static const value_string org_csapi_fw_TpLoadStatusError[] = {",

        "                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~",

        "/tmp/wireshark-master/epan/dissectors/packet-parlay.c:4084:27: warning: 'org_csapi_fw_TpFWExceptionType' defined but not used [-Wunused-const-variable=]",

        " static const value_string org_csapi_fw_TpFWExceptionType[] = {",

        "                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~",

        "/tmp/wireshark-master/epan/dissectors/packet-parlay.c:4041:27: warning: 'org_csapi_fw_TpAPIUnavailReason' defined but not used [-Wunused-const-variable=]",

        " static const value_string org_csapi_fw_TpAPIUnavailReason[] = {",

        "                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~",

        "Unable to open /tmp/wireshark-master/.svn/entries",

        "In file included from /tmp/wireshark-master/caputils/iface_monitor.c:55:0:",

        "/_usr/include/net/if.h:129:0: error: \"IFNAMSIZ\" redefined [-Werror]",

        " # define IFNAMSIZ IF_NAMESIZE",

        " ",

        "In file included from /usr/include/libnl3/netlink/netlink.h:24:0,",

        "                 from /usr/include/libnl3/netlink/msg.h:15,",

        "                 from /tmp/wireshark-master/caputils/iface_monitor.c:40:",

        "/usr/include/libnl3/netlink/netlink-compat.h:21:0: note: this is the location of the previous definition",

        " #define IFNAMSIZ 16",

        " ",

        "cc1: all warnings being treated as errors",

        "make[2]: *** [caputils/CMakeFiles/caputils.dir/iface_monitor.c.o] Error 1",

        "make[1]: *** [caputils/CMakeFiles/caputils.dir/all] Error 2",

        "make[1]: *** Waiting for unfinished jobs....",

        "make: *** [all] Error 2"

It looks like iface_monitor.c should be modified so as to include net/if.h before netlink/msg.h. Could you give it a try?

That said the comments in the file suggest that net/if.h needs to be included after libnl include (at least for some versions). But netlink-compat.h defines IFNAMESIZ only if it not defined yet... Another chicken and egg situation?

Pascal.