Wireshark-dev: Re: [Wireshark-dev] compiling asn.1 dissectors in Linux
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: João Valverde <joao.valverde@xxxxxxxxxxxxxxxxxx>
Date: Tue, 12 Apr 2016 18:48:20 +0100


On 12-04-2016 18:13, João Valverde wrote:



On 12-04-2016 18:04, João Valverde wrote:



On 11-04-2016 22:37, João Valverde wrote:



On 11-04-2016 21:33, Guy Harris wrote:

On Apr 11, 2016, at 1:13 PM, Born In <d3c1978@xxxxxxxxx> wrote:


Thank you. Was able to get past this.

Have another seemingly basic question. How do you append a suffix to
the version number of custom compiled version of wireshark?
The Windows method of using an environment variable doesn't seem to
be working in Linux


There are multiple build systems for Wireshark:

    1) autotools (UN*X-only - *maybe* you can try it on Windows with
Cygwin, but we don't support it);

    2) nmake (Windows-only)

    3) CMake (UN*X and Windows).

With nmake and CMake, the WIRESHARK_VERSION_FLAVOR environment
variable should work, on Windows or, for CMake, UN*X.

With autotools, that doesn't work - you'd have to manually edit the
script.

Is there any reason not to have the configure script check
WIRESHARK_VERSION_FLAVOR and, if it's set, use it, the same way the
nmake files and CMake files do?



Done in https://code.wireshark.org/review/#/c/14886/



The WIRESHARK_VERSION_EXTRA environment variable is also not supported
but because AC_INIT defines VERSION statically the usefulness of an
environment variable seems doubtful. It will not work during configure.

Currently make-version.pl -r must be run before autogen.sh to influence
the VERSION macro (or else use VCSVERSION).


Also "version extra" for autotools is what cmake calls "version build",
I think.

So, no "version extra" equivalent for autotools exists right now.
___________________________________________________________________________
I thought "extra" was an addition to "build", but it's not, it's a replacement, so I think it's still useful when running autogen.sh as a static tag instead of the usual git revision. Should be doable.