Wireshark · Wireshark-dev: Re: [Wireshark-dev] Make CMake reuse Makefile.common?

[Graham Bloice <graham.bloice@xxxxxxxxxxxxx>]

On 6 March 2015 at 15:17, Peter Wu <peter@xxxxxxxxxxxxx> wrote:

On Tue, Mar 03, 2015 at 05:50:10PM +0100, Alexis La Goutte wrote:
> On Mon, Mar 2, 2015 at 1:16 PM, Peter Wu <peter@xxxxxxxxxxxxx> wrote:
>
> > Hi,
> >
> > Recently there have been two issues due to separate copies between CMake
> > and autofoo (missing ATH dissector, missing field registrations for
> > plugins).
> >
> > The former could occur due to missing duplication from Makefile.common
> > into CMakeLists.txt. The latter happens because the
> > plugins/*/CMakeLists.txt are slightly different than the Makefiles (in
> > terms of variable sets).
> >
> > Hereby I am proposing to convert Makefile.common automatically to
> > CMakeLists.inc.txt, and then include that during the build process to
> > set variables. The inspiration comes from cURL which too supports
> > autoconf, and (as an experimental option) cmake.
> >
> > See this transformation macro[0] and its use[1] for an example.
> >
> Hi Peter,
>
> Need to try... but i known CMake cURL is no perfect... and there is some
> plan to drop support of CMake ;-)

There *was* a plan to drop CMake support if nobody cared, but since then
patches have been sent to improve it (also from my side).

> And also if i remember the target is only have CMake for build system (and
> remove autofoo...)

That would be great, but I would not rush this yet, there are still some
cmake issues like
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=10074. (other issues
I have found, but for which no bug is filled: the path to xdg-open is
fully expanded by cmake).

How are the windows binaries currently build? Using nmake I believe?

As mentioned elsewhere Windows CMake is getting good now, still some issues to be sorted, but I'm hopeful of getting there by SF15.

--

Graham Bloice