Wireshark · Wireshark-dev: [Wireshark-dev] Make CMake reuse Makefile.common?

[Peter Wu <peter@xxxxxxxxxxxxx>]

Hi,

Recently there have been two issues due to separate copies between CMake
and autofoo (missing ATH dissector, missing field registrations for
plugins).

The former could occur due to missing duplication from Makefile.common
into CMakeLists.txt. The latter happens because the
plugins/*/CMakeLists.txt are slightly different than the Makefiles (in
terms of variable sets).

Hereby I am proposing to convert Makefile.common automatically to
CMakeLists.inc.txt, and then include that during the build process to
set variables. The inspiration comes from cURL which too supports
autoconf, and (as an experimental option) cmake.

See this transformation macro[0] and its use[1] for an example.
-- 
Kind regards,
Peter Wu
https://lekensteyn.nl

 [0]: https://github.com/bagder/curl/blob/master/CMakeLists.txt#L986
 [1]: https://github.com/bagder/curl/blob/master/tests/libtest/CMakeLists.txt#L31