Wireshark-dev: Re: [Wireshark-dev] Gerrit patches with trailing whitespace
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Graham Bloice <graham.bloice@xxxxxxxxxxxxx>
Date: Mon, 25 Aug 2014 18:21:02 +0100
On 25 August 2014 18:17, Graham Bloice <graham.bloice@xxxxxxxxxxxxx> wrote:
On 25 August 2014 18:11, Juan Jose Martin Carrascosa <juanjo@xxxxxxx> wrote:
I think that you are talking about my just committed changes. I just did it and I just checked in the website that it has the whitespaces...

As Evan said, I don't have it installed by default and I wasn't really aware of the process (even reading the doc a couple of times). I am really sorry.

I will take a look at how to "stop" my changes from being reviewed and fix it.

Thanks!
Juanjo

It's just a trivial thing to have to go around the submission loop once again.  Annoying for both the submitter and the reviewer, as we all know trailing white space is a heinous crime :-) 

Did git-review install the hook for me, I can't think where else it came from?


Should we add some info then to the Dev Guide as to where to get the hook, and also run a server-side hook to reject the push?

--
Graham Bloice