Wireshark · Wireshark-dev: Re: [Wireshark-dev] Gerrit patches with trailing whitespace

[Juan Jose Martin Carrascosa <juanjo@xxxxxxx>]

I think that you are talking about my just committed changes. I just did it and I just checked in the website that it has the whitespaces...

As Evan said, I don't have it installed by default and I wasn't really aware of the process (even reading the doc a couple of times). I am really sorry.

I will take a look at how to "stop" my changes from being reviewed and fix it.

Thanks!

Juanjo

On Mon, Aug 25, 2014 at 7:08 PM, Evan Huus <eapache@xxxxxxxxx> wrote:

Probably they are simply not installing the hook - none of our tooling
sets it up by default that I'm aware of.

On Mon, Aug 25, 2014 at 1:06 PM, Graham Bloice
<graham.bloice@xxxxxxxxxxxxx> wrote:
> When reviewing some submissions on Gerrit, I've noted a few with trailing
> whitespace.  The git pre-commit hook always warns me of this, so how are
> folks managing to do this?  Are they using clients that ignore the hook?
>
> --
> Graham Bloice
>

> ___________________________________________________________________________
> Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
> Archives:    http://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
>              mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe