Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 53090: /trunk/ /trunk/asn1/acse/: ac
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
Date: Fri, 10 Jan 2014 19:59:45 +0100
On Fri, Jan 10, 2014 at 12:56 PM, Stig Bjørlykke <stig@xxxxxxxxxxxxx> wrote:
> This commit introduced a bug where I always get
> "[Malformed Packet: PRES]" in X.400 traffic.

Reassembly in RTSE is a bit special. The reassembly is done when
receiving a SES "MAJOR SYNC POINT", as this indicates the end of the
COTP DT Data stream.  The payload for this pdu is empty, which results
in a empty tvb being sent to RTSE (which then reassemble all previous
received payloads).

Updating the RTSE dissector to a new-style was done by returning
tvb_length(tvb), which in this case is always 0.  Returning 0 from a
new-style dissector means this package was not for us, which is wrong
in this case.

I've added a fix for this in 54693.


-- 
Stig Bjørlykke