Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 53090: /trunk/ /trunk/asn1/acse/: ac
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
Date: Fri, 10 Jan 2014 12:56:01 +0100
On Tue, Nov 5, 2013 at 7:47 PM,  <mmann@xxxxxxxxxxxxx> wrote:
> Log:
>  In an effort to reduce the use of pinfo->private_data (and some true global variables), I converted the ASN.1 dissectors that use pinfo->private_data to exchange a SESSION_DATA_STRUCTURE to instead only exchange it in the context of ASN.1.  This meant converting dissectors to the "new" style to pass the SESSION_DATA_STRUCTURE as well as providing a pointer to it in asn1_ctx_t.private_data.  Yes, it's still "private data", but it's not used by all dissectors like pinfo->private data is.


This commit introduced a bug where I always get "[Malformed Packet:
PRES]" in X.400 traffic.

Have a look at this sample capture, frame 20:

http://wiki.wireshark.org/SampleCaptures?action=AttachFile&do=get&target=p772-transfer-success.pcap


-- 
Stig Bjørlykke