Wireshark-dev: Re: [Wireshark-dev] Wireshark PIDL generated dissectors
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Pascal Quantin <pascal.quantin@xxxxxxxxx>
Date: Mon, 4 Nov 2013 12:13:14 +0100
Hi,

Le 4 nov. 2013 à 09:24, Matthieu Patou <mat@xxxxxxxxx> a écrit :

> On 11/03/2013 11:37 AM, Pascal Quantin wrote:
>> Hi,
>> 
>> there is also a small issue spotted by checkAPIs.pl script (found in tools
>> folder) leading to a failure of the buildbot:
>> Error: the name for
>> hf_frsrpc_frsrpc_FrsVerifyPromotionParent___ndr_guid_size
>> ("frsrpc.frsrpc_FrsVerifyPromotionParent.__ndr_guid_size") has leading
>> space in packet-dcerpc-frsrpc.c
>> Error: the name for
>> hf_frsrpc_frsrpc_FrsStartPromotionParent___ndr_guid_size
>> ("frsrpc.frsrpc_FrsStartPromotionParent.__ndr_guid_size") has leading space
>> in packet-dcerpc-frsrpc.c
>> I fixed them manually in r53072 but you probably want to change the code
>> generator so as to remove the prepended spaces.
> Just to be sure
> are we speaking of:
> { &hf_frsrpc_frsrpc_FrsVerifyPromotionParent___ndr_guid_size,
> { "  Ndr Guid Size", "frsrpc.frsrpc_FrsVerifyPromotionParent.__ndr_guid_size", FT_UINT32, BASE_DEC, NULL, 0, NULL, HFILL }},
> ^^^^
> HERE ?
> 
> If so I think that the patch
> http://git.samba.org/mat/?p=mat/samba.git;a=blobdiff;f=pidl/lib/Parse/Pidl/Wireshark/NDR.pm;h=70561e39263b3a3332079e40fb842bb96d281924;hp=a021398b381fd229fe12e3f5a27a443497ac54ff;hb=9359e5b6b9d005c376b950ea18d38be9c0c7739a;hpb=86c92c8ddd7387a2dca227c2b3abbfcdc7d765cd
> 
> Will do that once merge in the main tree.

Perfect, thanks for the follow-up.

Pascal.