Wireshark · Wireshark-dev: Re: [Wireshark-dev] Fwd: [Wireshark-commits] rev 53073: /trunk/epan/dissectors/ /trunk/epan/dissecto

[Anders Broman <anders.broman@xxxxxxxxxxxx>]

-----Original Message-----
From: wireshark-dev-bounces@xxxxxxxxxxxxx [mailto:wireshark-dev-bounces@xxxxxxxxxxxxx] On Behalf Of Joerg Mayer
Sent: den 4 november 2013 00:19
To: Developer support list for Wireshark
Subject: Re: [Wireshark-dev] Fwd: [Wireshark-commits] rev 53073: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-btavdtp.c

On Mon, Nov 04, 2013 at 12:02:23AM +0100, Anders Broman wrote:
>> 
>> What was the rationale for this change?
...
>> [-Wmissing-prototypes]
>> 
>> on the Ubuntu buildbot.
>
>OK, looks like I missed something: We have this kind of forward declarations in ~72% of the dissectors but not in the remaining ones. Maybe we should decide on one style and fix the remaining dissectors?
>

I'd vote for fixing the remaining ones.



-- 
Joerg Mayer                                           <jmayer@xxxxxxxxx>
We are stuck with technology when what we really want is just stuff that works. Some say that should read Microsoft instead of technology.
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe