Wireshark-dev: Re: [Wireshark-dev] Remove hf_ variables
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Graham Bloice <graham.bloice@xxxxxxxxxxxxx>
Date: Wed, 14 Aug 2013 09:26:17 +0100
On 13 August 2013 17:53, Jakub Zawadzki <darkjames-ws@xxxxxxxxxxxx> wrote:
On Fri, Aug 09, 2013 at 08:31:02PM +0200, Jakub Zawadzki wrote:
> On Wed, Aug 07, 2013 at 08:10:21PM +0200, Jakub Zawadzki wrote:
> > I wrote some ugly gawk program for hf_ variables.
> >
> > Here is one + some patch for epan:
> > http://www.wireshark.org/~darkjames/proto-new/0001-changes.txt
> >
> > Here is convertion of some dissectors (not quite automagic):
> > http://www.wireshark.org/~darkjames/proto-new/0002-rewrite.txt
> >
> > We probably don't want this redefine macros inside proto-new.h but it's *much faster*
> > to test.
>
> Removed in v2:
>
> http://www.wireshark.org/~darkjames/proto-new-v2/0001-changes.txt
> http://www.wireshark.org/~darkjames/proto-new-v2/0002-rewrite.txt
>
> Changes from v1:
>  - proto_tree_add_item() now takes pointer to header_field_info *,
>    if NEW_PROTO_TREE_API NOT defined small compatilibity macro is used.
>  - convert names just to hfi_ not hfi_hf_
>  - fix proto_get_first_protocol_field(), proto_get_next_protocol_field()

Ping, any feedback?

Also missing final approval/reject (/me smiles to Gerald) ;]


It's not entirely clear to me from the thread what the current intent is.  Your current plan is just the removal of hf vars?

You'll also need to update the docs, README.dissector is the most obvious, then everyone's presentations on how to build a dissector :-)