Wireshark-dev: Re: [Wireshark-dev] Remove hf_ variables
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Jakub Zawadzki <darkjames-ws@xxxxxxxxxxxx>
Date: Fri, 9 Aug 2013 20:31:02 +0200
On Wed, Aug 07, 2013 at 08:10:21PM +0200, Jakub Zawadzki wrote:
> I wrote some ugly gawk program for hf_ variables.
> 
> Here is one + some patch for epan:
> http://www.wireshark.org/~darkjames/proto-new/0001-changes.txt
> 
> Here is convertion of some dissectors (not quite automagic):
> http://www.wireshark.org/~darkjames/proto-new/0002-rewrite.txt
> 
> We probably don't want this redefine macros inside proto-new.h but it's *much faster*
> to test.

Removed in v2:

http://www.wireshark.org/~darkjames/proto-new-v2/0001-changes.txt
http://www.wireshark.org/~darkjames/proto-new-v2/0002-rewrite.txt

Changes from v1:
 - proto_tree_add_item() now takes pointer to header_field_info *, 
   if NEW_PROTO_TREE_API NOT defined small compatilibity macro is used.
 - convert names just to hfi_ not hfi_hf_
 - fix proto_get_first_protocol_field(), proto_get_next_protocol_field()