Wireshark · Wireshark-dev: Re: [Wireshark-dev] idl2wrs generation of display filters

[mmann78@xxxxxxxxxxxx]

No, I didn't really want to muck with it.  The patch is a single line, so I can check it in, but I didn't know if I needed to regenerate the dissector files too, or if that came for "free" somehow (like a distclean, then build).  Sounds like that's a "no".

 

If I need to have omniorb stuff, and you'd like the patch + the dissectors checked into a single revision, it'd be much easier if you did it.  Timetable isn't really an issue, I'm just slowly cleaning up display filters to be ready for the 1.10 release.

 

-----Original Message-----
From: Jeff Morriss <jeff.morriss.ws@xxxxxxxxx>
To: Developer support list for Wireshark <wireshark-dev@xxxxxxxxxxxxx>
Sent: Thu, Jul 26, 2012 1:55 pm
Subject: Re: [Wireshark-dev] idl2wrs generation of display filters

mmann78@xxxxxxxxxxxx wrote:
> I was running checkfiltername.pl and discovered that the idl2wrs 
> generated dissectors don't follow the convention of using the filter 
> name registered with the protocol as the start of any display filter 
> name.  Was this just an oversight, or was it intentional?
> 
> I believe the attached patch will fix the problem, but I don't know the 
> first thing about the idl2wrs generation or how to regenerate the 
> necessary dissector files, so  I thought I'd send it out for comment.

I don't know much about the IDL stuff but I recently made a bunch of 
changes to it (and rebuilt the dissectors).  My cheat-sheet for how to 
re-generate them came from this check-in comment:

http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=39932

:-)

(Of course you also need the omniorb stuff, etc. first.)

If you don't want to muck with it I could try to apply this patch and 
regenerate but it'll probably be a few days before I'll have a chance.
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe