Wireshark · Wireshark-dev: [Wireshark-dev] idl2wrs generation of display filters

[mmann78@xxxxxxxxxxxx]

I was running checkfiltername.pl and discovered that the idl2wrs generated dissectors don't follow the convention of using the filter name registered with the protocol as the start of any display filter name.  Was this just an oversight, or was it intentional?

I believe the attached patch will fix the problem, but I don't know the first thing about the idl2wrs generation or how to regenerate the necessary dissector files, so  I thought I'd send it out for comment.

 

Index: tools/wireshark_gen.py
===================================================================
--- tools/wireshark_gen.py	(revision 43966)
+++ tools/wireshark_gen.py	(working copy)
@@ -1641,7 +1641,7 @@
 
    static hf_register_info hf[] = {
         /* field that indicates the currently ongoing request/reply exchange */
-		{&hf_operationrequest, {"Request_Operation","@protocol_name@.Request_Operation",FT_STRING,BASE_NONE,NULL,0x0,NULL,HFILL}},
+		{&hf_operationrequest, {"Request_Operation","giop-@dissector_name@.Request_Operation",FT_STRING,BASE_NONE,NULL,0x0,NULL,HFILL}},
 
       /* no fields yet */