Wireshark-dev: Re: [Wireshark-dev] dumpcap does not recognize option "-t" (usethreads)
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: "Speck Michael EHWG AVL/GAE" <Michael.Speck@xxxxxxx>
Date: Wed, 9 Nov 2011 10:12:59 +0100
Thanks Guy for the fast response.
Attached is a patch that fixes dumpcap.c





-----Original Message-----
From: wireshark-dev-bounces@xxxxxxxxxxxxx [mailto:wireshark-dev-bounces@xxxxxxxxxxxxx] On Behalf Of Guy Harris
Sent: Mittwoch, 9. November 2011 09:49
To: Developer support list for Wireshark
Subject: Re: [Wireshark-dev] dumpcap does not recognize option "-t" (usethreads)


On Nov 9, 2011, at 12:42 AM, Speck Michael EHWG AVL/GAE wrote:

> 1.) how to tell the build system that "USE_THREADS" should be defined?

USE_THREADS should not be defined in the SVN trunk any more; threads should always be used.  Nothing in Wireshark should be checking for USE_THREADS any more; if anything is, that's a bug.

The right fix is to get rid of OPTSTRING_t, and just put the "t" in the option string unconditionally.  All the stuff that checks whether USE_THREADS is defined should be rewritten to act as if it's always defined.

Attachment: get_rid_of_USE_THREADS_dumpcap.c.patch
Description: get_rid_of_USE_THREADS_dumpcap.c.patch