Wireshark-dev: Re: [Wireshark-dev] dumpcap does not recognize option "-t" (use threads)
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Guy Harris <guy@xxxxxxxxxxxx>
Date: Wed, 9 Nov 2011 00:48:38 -0800
On Nov 9, 2011, at 12:42 AM, Speck Michael EHWG AVL/GAE wrote:

> 1.) how to tell the build system that "USE_THREADS" should be defined?

USE_THREADS should not be defined in the SVN trunk any more; threads should always be used.  Nothing in Wireshark should be checking for USE_THREADS any more; if anything is, that's a bug.

The right fix is to get rid of OPTSTRING_t, and just put the "t" in the option string unconditionally.  All the stuff that checks whether USE_THREADS is defined should be rewritten to act as if it's always defined.