Wireshark · Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 38515: /trunk/gtk/ /trunk/gtk/: capture_dlg.c capture_if

[Michael Tüxen <Michael.Tuexen@xxxxxxxxxxxxxxxxx>]

On Aug 13, 2011, at 10:26 PM, Stig Bjørlykke wrote:

> On Sat, Aug 13, 2011 at 9:21 PM,  <guy@xxxxxxxxxxxxx> wrote:
>> Log:
>>  Say "none" rather than "unknown" if there are no IP addresses; in most
>>  if not all cases, it's not that we don't know the IP addresses, it's
>>  that there are no IP addresses to know.
> 
> What about displaying nothing in the interface list, and "none" in the details?
> Like in the attached patch.
I've committed the patch in r38520 which some whitespace changes.
Thanks for providing it.
> 
> BTW, why do we build the same string ("<b>%s</b>\n<span
> size='small'>%s</span>") 4 different places?
Two for the initial setup of the interface list, one might be able
to reduce it to one.

One for adding a row (when adding a new remote interface)

One for updating a row.

Best regards
Michael
> 
> 
> -- 
> Stig Bjørlykke
> <interface-list-no-none.patch>___________________________________________________________________________
> Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
> Archives:    http://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
>             mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe