Wireshark-dev: Re: [Wireshark-dev] [PATCH][UPDATE] analyzing SHIM6 protocol
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Matthijs Mekking <matthijs@xxxxxxxxxxxx>
Date: Mon, 26 Mar 2007 11:29:13 +0200
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hello,

> - in hf_register_info, there are two items of the same name :
> hf_ipv6_shim6_opt_len

This is fixed in the source and in the patch.

> - you should create an helper function to add hf_ipv6_shim6_ct to the tree.

I know, but at the moment I don't have the time to figure that out.

> - instead of dissect_shim_ip_addr, use
> proto_tree_add_item/proto_tree_add_ipv6. The type of the item is then
> FT_IPv6.

Replaced all occurences of dissect_shim_ip_addr.

In two weeks time I should have more time. Than I will look at the
hf_ipv6_shim6_ct. Expect a new patch at that time.

Regards,

Matthijs

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGB5JpNiaStnTWEtYRAhopAKC+IftlWBK+fuT0p3n9S9s8xD0E+wCcCdc3
eqOz1UMNMsmM0xc6n+T/r6c=
=Fm6B
-----END PGP SIGNATURE-----