Hi,
some quick comments :
- in hf_register_info, there are two items of the same name :
hf_ipv6_shim6_opt_len
- you should create an helper function to add hf_ipv6_shim6_ct to the tree.
- instead of dissect_shim_ip_addr, use
proto_tree_add_item/proto_tree_add_ipv6. The type of the item is then
FT_IPv6.
Regards,
Sebastien Tandel
Matthijs Mekking wrote:
> Thanks for the advice. I have attached a new patch, were you can apply
> shim6 elements as filter easier.
>
> more info at www.pletterpet.nl/shim6/
>
> Regards,
>
> Matthijs Mekking
> matthijs@xxxxxxxxxxxx
> NLNetLabs Amsterdam / Radboud University Nijmegen
>
> Sebastien Tandel wrote:
> > I think most the proto_tree_add_text could be replaced by
> > proto_tree_add_item which could allow (i.e. at least Sébastien Barré ;))
> > to perform an easy search on specific items. ;)
>
>
> > Regards,
> > Sebastien Tandel
>
> > Matthijs Mekking wrote:
> >> Hello,
> >>
> >> The last two months I have been working on a SHIM6 enabled version of
> >> Wireshark. The subject of my final thesis is about SHIM6 and I
> needed to
> >> analyze the SHIM6 communication exchange. SHIM6 is an IPv6 based
> >> solution for multihoming.(www.shim6.org)
> >>
> >> SHIM6 is handled as an IPv6 extension header. So I have changed the
> >> source and header files of packet-ipv6. I have added dissecting
> >> functions for different the message formats of the SHIM6 protocol.
> >> I also needed to change the ipproto files to add the new extension
> >> header. The included patch is pretty clear about that.
> >>
> >> The message formats are conform the latest draft specification of
> SHIM6:
> >> http://tools.ietf.org/html/draft-ietf-shim6-proto-07
> >> http://tools.ietf.org/html/draft-ietf-shim6-failure-detection-07
> >>
> >> Regards,
> >>
> >> Matthijs Mekking
> >> matthijs@xxxxxxxxxxxx
> >> NLNetLabs Amsterdam / Radboud University Nijmegen
> > _______________________________________________
> > Wireshark-dev mailing list
> > Wireshark-dev@xxxxxxxxxxxxx
> > http://www.wireshark.org/mailman/listinfo/wireshark-dev
>
