Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 20609: /trunk/ /trunk/:config.h.win3
The logic of this looks wrong to me in one sense - the message tells you
that your compiler is 14.00 when it is not (I'm still using 12.00). I
would have thought it should be reversed, so that given a compiler
number, it checks that the variant is one of the accepted values.
More importantly, I tried adding these lines:
#define WS_TO_STRING2(x) #x
#define WS_TO_STRING(x) WS_TO_STRING2(x)
#pragma message( "_MSC_VER: " WS_TO_STRING(_MSC_VER))
#pragma message( "MSVC_VARIANT: " WS_TO_STRING(MSVC_VARIANT) )
I then get:
_MSC_VER: 1200
MSVC_VARIANT: MSVC_VARIANT
I don't think that MSVC_VARIANT, or any of the constants it's being
compared against, are actually getting defined.
I can't see anything in config.nmake that would actually cause them to
be passed to the preprocessor. Am I missing something?
Cheers
Doug
-----Original Message-----
From: wireshark-dev-bounces@xxxxxxxxxxxxx
[mailto:wireshark-dev-bounces@xxxxxxxxxxxxx] On Behalf Of Ulf Lamping
Sent: 29 January 2007 22:23
To: wireshark-dev@xxxxxxxxxxxxx
Subject: Re: [Wireshark-dev] [Wireshark-commits] rev 20609: /trunk/
/trunk/:config.h.win32
etxrab@xxxxxxxxxxxxx wrote:
> http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=20609
>
> User: etxrab
> Date: 2007/01/29 08:58 PM
>
> Log:
> Comment out Ulfs changes to be able to do a test build.
>
>
Could you please explain that a bit further ?!?
If there's a bug in the logic, it should be fixed - and if it's ok, you
shouldn't just remove it ...
Regards, ULFL
_______________________________________________
Wireshark-dev mailing list
Wireshark-dev@xxxxxxxxxxxxx
http://www.wireshark.org/mailman/listinfo/wireshark-dev
This message should be regarded as confidential. If you have received this email in error please notify the sender and destroy it immediately.
Statements of intent shall only become binding when confirmed in hard copy by an authorised signatory. The contents of this email may relate to dealings with other companies within the Detica Group plc group of companies.
Detica Limited is registered in England under No: 1337451.
Registered offices: Surrey Research Park, Guildford, Surrey, GU2 7YP, England.
