Wireshark-commits: [Wireshark-commits] master a5703f2: More changes arising from PVS-Studio output.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 06 May 2020 08:35:19 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a5703f22cb723c46d5700cf3fffc8a9b40dd47d3
Submitter: "Martin Mathieson <martin.r.mathieson@xxxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

a5703f2 by Martin Mathieson (martin.r.mathieson@xxxxxxxxxxxxxx):

    More changes arising from PVS-Studio output.
    
    /opt/SourceCode/wireshark/epan/dissectors/packet-ip.c	1556	err	V547 Expression 'opt == (1 | 0x00)' is always true.
    /opt/SourceCode/wireshark/epan/dissectors/packet-ipdc.c	739	warn	V547 Expression 'payload_len < 4' is always false.
    /opt/SourceCode/wireshark/ui/text_import.c	1049	err	V547 Expression 'info->offset_type == OFFSET_DEC' is always true.
    
    None of these are actual bugfixes.
    
    Bug: 16335
    Change-Id: I6d0d3bb92c70ea625fc8b559e7a2bc5ba4e29e25
    Reviewed-on: https://code.wireshark.org/review/37136
    Petri-Dish: Martin Mathieson <martin.r.mathieson@xxxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Martin Mathieson <martin.r.mathieson@xxxxxxxxxxxxxx>
    

Actions performed:

    from  1d0b233   Qt: Stretch last packet list header section
     add  a5703f2   More changes arising from PVS-Studio output.


Summary of changes:
 epan/dissectors/packet-ip.c   |  6 ++----
 epan/dissectors/packet-ipdc.c |  5 +----
 ui/text_import.c              | 20 +++++++++++++++-----
 3 files changed, 18 insertions(+), 13 deletions(-)