Wireshark · Wireshark-commits: [Wireshark-commits] master-3.2 5ce52f7: Qt: Stretch last packet list header section

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5ce52f748553b9bf5d3ef1882af6ceb9cdb0f50a
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master-3.2
Repository: wireshark

Commits:

5ce52f7 by Tomasz Moń (desowin@xxxxxxxxx):

    Qt: Stretch last packet list header section
    
    Programatically show the master split widget before elements are added
    to prevent pending resize events from resizing packet columns to insane
    widths (in my case orders of magnitude higher than display resolution)
    
    Such resize was occuring when loading capture file if configuration file
    included hidden columns (e.g. 55 defined columns, 8 visible). The resize
    was not directly visible to user. Resize event call chain included calls
    to recent_set_column_width() that changed width stored in configuration.
    Modified configuration column width value would become effective after
    user added or removed columns.
    
    Hide PacketList when freezing and show it when thawing. Do not call
    setUpdatesEnabled(false) as it leads to widget/preferences columns
    missynchronization.
    
    Clear packet list before freeing frame data. This prevents accessing
    freed memory in ProtoTree on file close if packet list was in focus and
    the next widget to get focus is packet details.
    
    Ping-Bug: 16063
    Bug: 16491
    Change-Id: I2c21d928348681af1793b3263815c81ee73d41b0
    Reviewed-on: https://code.wireshark.org/review/37029
    Petri-Dish: Tomasz Moń <desowin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit 1d0b233f12e937f6278fc38775fca530e2be2661)
    Reviewed-on: https://code.wireshark.org/review/37155
    Petri-Dish: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    

Actions performed:

    from  62bd075   SOMEIP: removing warnings due to guint64 (%lx vs %llx)
     add  5ce52f7   Qt: Stretch last packet list header section


Summary of changes:
 file.c                               | 10 +++++-----
 ui/qt/main_window_layout.cpp         |  4 ++++
 ui/qt/packet_list.cpp                |  4 ++--
 ui/qt/widgets/packet_list_header.cpp |  2 +-
 4 files changed, 12 insertions(+), 8 deletions(-)