Wireshark · Wireshark-commits: [Wireshark-commits] master-3.2 67161b5: CoAP: change detection logic for CoAP over TCP or TLS

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=67161b509b5ee19a855e406c9601e5037523cd68
Submitter: "Pascal Quantin <pascal@xxxxxxxxxxxxx>"
Changed: branch: master-3.2
Repository: wireshark

Commits:

67161b5 by Pascal Quantin (pascal@xxxxxxxxxxxxx):

    CoAP: change detection logic for CoAP over TCP or TLS
    
    Do not assume that having a TCP port means that CoAP is running directly
    over TCP: this is not the case with MQTT for example (see bug 14591 for
    a capture). Instead explicitly check that the parent dissector is TCP or
    TLS.
    
    Bug: 15910
    Change-Id: Ib4880623b8525fe6be52a685397005eac86da135
    Reviewed-on: https://code.wireshark.org/review/35879
    Petri-Dish: Pascal Quantin <pascal@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    (cherry picked from commit 75e1b69e88bb6856bbae443aa64efdceb3e39117)
    Reviewed-on: https://code.wireshark.org/review/35894
    Reviewed-by: Pascal Quantin <pascal@xxxxxxxxxxxxx>
    

Actions performed:

    from  218620a   ICMP/ICMPv6: fix request/response tracking for checksum 0x0000
     add  67161b5   CoAP: change detection logic for CoAP over TCP or TLS


Summary of changes:
 epan/dissectors/packet-coap.c | 21 ++++++++++++++++-----
 1 file changed, 16 insertions(+), 5 deletions(-)