Wireshark-commits: [Wireshark-commits] master d44c5e4: x509af, ocsp, ber: display serialNumber (INT
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 21 Jan 2020 22:10:53 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d44c5e45cbb5e9ece96cab6a62793dd24ec52b7d
Submitter: "Peter Wu <peter@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

d44c5e4 by Peter Wu (peter@xxxxxxxxxxxxx):

    x509af,ocsp,ber: display serialNumber (INTEGER) as bytes
    
    Certificates used in TLS typically have a serial number larger than 64
    bits which do not fit in FT_UINT64 and results in use of the synthetic
    ber.64bit_uint_as_bytes field name. To enable use of ocsp.serialNumber
    and x509af.serialNumber field names, define these as bytes instead.
    
    Update the BER dissector to allow INTEGER types to use FT_BYTES.
    
    Bug: 16339
    Change-Id: Id58075b450d86aff6b616c359900ae83a3ec2f51
    Reviewed-on: https://code.wireshark.org/review/35868
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Pascal Quantin <pascal@xxxxxxxxxxxxx>
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  75e1b69   CoAP: change detection logic for CoAP over TCP or TLS
     add  d44c5e4   x509af,ocsp,ber: display serialNumber (INTEGER) as bytes


Summary of changes:
 epan/dissectors/asn1/ocsp/ocsp.cnf     |  2 +-
 epan/dissectors/asn1/x509af/x509af.cnf |  2 +-
 epan/dissectors/packet-ber.c           | 10 ++++++++++
 epan/dissectors/packet-ocsp.c          |  2 +-
 epan/dissectors/packet-x509af.c        |  6 +++---
 5 files changed, 16 insertions(+), 6 deletions(-)