Wireshark-commits: [Wireshark-commits] master d5cfa99: Allow Multiselection of packets to work duri
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 12 Jan 2020 22:33:49 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d5cfa99217197719b251cd01c5425f6614d344d3
Submitter: "Michael Mann <mmann78@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

d5cfa99 by Dylan Ulis (daulis0@xxxxxxxxx):

    Allow Multiselection of packets to work during live captures
    
    During live capture, the previous logic was to jump to row 1 when there is no
    'current_frame'. When multiselect is active, there is no 'current_frame', so
    it would always jump back to row 1, when >1 packet was selected.
    
    Bug: 16293
    Change-Id: Id1c9eb36fcae83f67ae342be6f9dfc1405ce7025
    Reviewed-on: https://code.wireshark.org/review/35747
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  f582c85   netlink: use value retrieval with proper encoding
     add  d5cfa99   Allow Multiselection of packets to work during live captures


Summary of changes:
 file.c                | 2 +-
 ui/qt/packet_list.cpp | 9 +++++++++
 ui/ws_ui_util.h       | 1 +
 3 files changed, 11 insertions(+), 1 deletion(-)