Wireshark · Wireshark-commits: [Wireshark-commits] master f582c85: netlink: use value retrieval with proper encoding

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f582c85623bbc4d9cc66564403d3500b9398e1e9
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

f582c85 by Jaap Keuter (jaap.keuter@xxxxxxxxx):

    netlink: use value retrieval with proper encoding
    
    This change fixes the problem of value retrieval being done:
    1. without regard for the declared encoding,
    2. multiple times, for addition to other tree items.
    
    The first issue can result in two different representations of the
    same field. The second is an optimization, and a way to make sure
    a consistent interpretation of the protocol field is made.
    
    Change-Id: Id521f4deafe381322195b1eb998138efcaa51f30
    Reviewed-on: https://code.wireshark.org/review/35745
    Reviewed-by: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    Petri-Dish: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  c84bbf4   Qt: Add error message when create profiles dir fails
     add  f582c85   netlink: use value retrieval with proper encoding


Summary of changes:
 epan/dissectors/packet-netlink-net_dm.c    | 30 ++++++------
 epan/dissectors/packet-netlink-netfilter.c |  4 +-
 epan/dissectors/packet-netlink-route.c     | 77 ++++++++++++++++--------------
 epan/dissectors/packet-netlink-sock_diag.c |  5 +-
 4 files changed, 59 insertions(+), 57 deletions(-)