Wireshark-commits: [Wireshark-commits] master ad2584f: tpncp: replace stack variable with dynamic a
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 10 Jan 2020 04:59:43 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ad2584f4373cfe79433f25f30a4e11c0b928f70e
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

ad2584f by Dario Lombardo (lomato@xxxxxxxxx):

    tpncp: replace stack variable with dynamic allocation.
    
    The size of the stack triggers an error on clang:
    
    ../epan/dissectors/packet-tpncp.c:410:1: error: stack frame size of 26152 bytes
    in function 'init_tpncp_data_fields_info' [-Werror,-Wframe-larger-than=]
    init_tpncp_data_fields_info(tpncp_data_field_info *data_fields_info, FILE *file)
    ^
    1 error generated.
    
    Change-Id: Ia7d1d609b339eff6ffa023d9c0bf47caf6bd9851
    Reviewed-on: https://code.wireshark.org/review/35715
    Petri-Dish: Dario Lombardo <lomato@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  1bbac91   Qt: Fix related packet delegate
     add  ad2584f   tpncp: replace stack variable with dynamic allocation.


Summary of changes:
 epan/dissectors/packet-tpncp.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)