Wireshark-commits: [Wireshark-commits] master 1bbac91: Qt: Fix related packet delegate
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 10 Jan 2020 04:59:14 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1bbac91d33ea9711de1dd052fea74cbaff72761f
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

1bbac91 by Roland Knall (rknall@xxxxxxxxx):

    Qt: Fix related packet delegate
    
    Recent updates broke the related packet delegate in such a way,
    that the direction arrow for the current packet was shown, but
    no indicator for any other packet. This fix resets the packet
    indicator properly, if a new frame is selected.
    
    Note: This means, that the caller has to reset the delegate,
    but this was the original behavior anyway
    
    Bug: 16316
    Change-Id: Ief2396c65303a2226ad9fdd87969b667b2f1274d
    Reviewed-on: https://code.wireshark.org/review/35720
    Petri-Dish: Roland Knall <rknall@xxxxxxxxx>
    Reviewed-by: Roland Knall <rknall@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  e3a92cf   Qt+Win32: Tell the user to install Npcap/WinPcap if needed.
     add  1bbac91   Qt: Fix related packet delegate


Summary of changes:
 ui/qt/models/related_packet_delegate.cpp | 12 +++++++++++-
 ui/qt/models/related_packet_delegate.h   |  2 +-
 2 files changed, 12 insertions(+), 2 deletions(-)