Wireshark-commits: [Wireshark-commits] master 2925fb0: Use g_file_open_tmp within create_tempfile
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 20 Dec 2019 19:26:45 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2925fb0850ee3ab005dd02d69994390827c2e008
Submitter: "Roland Knall <rknall@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

2925fb0 by Michael Mann (mmann78@xxxxxxxxxxxx):

    Use g_file_open_tmp within create_tempfile
    
    Much better to use a known library than create it ourselves.
    
    Also remove get_tempfile_path as it's not used.
    
    Bug: 15992
    Change-Id: I17b9bd879e8bdb540f79db83c6c138f8ee724764
    Reviewed-on: https://code.wireshark.org/review/34420
    Reviewed-by: Tomasz Moń <desowin@xxxxxxxxx>
    Petri-Dish: Tomasz Moń <desowin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Roland Knall <rknall@xxxxxxxxx>
    

Actions performed:

    from  c247a83   wcp: skip buffer too long.
     add  2925fb0   Use g_file_open_tmp within create_tempfile


Summary of changes:
 debian/libwsutil0.symbols      |   1 -
 dumpcap.c                      |   8 +-
 extcap.c                       |   9 ++-
 file.c                         |   1 -
 ui/export_pdu_ui_utils.c       |  11 ++-
 ui/qt/endpoint_dialog.cpp      |  30 ++++----
 wiretap/file_access.c          |   8 +-
 wiretap/nettrace_3gpp_32_423.c |   9 ++-
 wsutil/tempfile.c              | 164 +++--------------------------------------
 wsutil/tempfile.h              |  17 +----
 10 files changed, 59 insertions(+), 199 deletions(-)