Wireshark · Wireshark-commits: [Wireshark-commits] master-3.2 da4f0e4: CMake: Create a DocBook stamp file for Visual Studio.

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=da4f0e457c530cf4cb18de996827583064c43400
Submitter: "Gerald Combs <gerald@xxxxxxxxxxxxx>"
Changed: branch: master-3.2
Repository: wireshark

Commits:

da4f0e4 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    CMake: Create a DocBook stamp file for Visual Studio.
    
    Create user-guide.xml-stamp and developer-guide.xml-stamp when building
    under Visual Studio. Fixes
    
    C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\MSBuild\Microsoft\VC\v160\Microsoft.CppCommon.targets(231,5): warning MSB8064: Custom build for item "C:\buildbot\builders\wireshark-master-32\windows-2019-x86\build\cmbuild\CMakeFiles\8721ce5c0a51a8e0d8e35fd55fbe2e6e\user-guide.hhp.rule" succeeded, but specified dependency "c:\buildbot\builders\wireshark-master-32\windows-2019-x86\build\cmbuild\docbook\user-guide.xml-stamp" does not exist. This may cause incremental build to work incorrectly. [C:\buildbot\builders\wireshark-master-32\windows-2019-x86\build\cmbuild\docbook\user_guide_chm.vcxproj]
    
    when building the user_guide_chm target.
    
    Change-Id: Ia224823841b4d3def3436f9f3a48b759694ffb37
    Reviewed-on: https://code.wireshark.org/review/35509
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit 6094e9d3922601f6c2eeb892c9bf5b46ff58ff5f)
    Reviewed-on: https://code.wireshark.org/review/35523
    

Actions performed:

    from  cfc7b08   extcap: fix use-after-free bug.
     add  da4f0e4   CMake: Create a DocBook stamp file for Visual Studio.


Summary of changes:
 cmake/modules/FindAsciidoctor.cmake | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)