Wireshark · Wireshark-commits: [Wireshark-commits] master caf8e70: GSM A-bis/OML: use more proto_tree_add_item() in dissect_oml_att

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=caf8e70dfe722e6c2e1e0ae2a1e489eb4d626f31
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

caf8e70 by Vadim Yanitskiy (axilirator@xxxxxxxxx):

    GSM A-bis/OML: use more proto_tree_add_item() in dissect_oml_attrs()
    
    In dissect_oml_attrs(), all pairs of:
    
      - val16 = tvb_get_ntohs(...);
      - proto_tree_add_uint(..., val16);
    
    can be replaced by generic proto_tree_add_item(..., ENC_BIG_ENDIAN).
    
    Change-Id: Id5a77b056d8e6bfafb1074d5e5ded853f64f168d
    Reviewed-on: https://code.wireshark.org/review/35514
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  5b08742   GSM A-bis/OML: use generic proto_tree_add_item() for IPv4 addresses
     add  caf8e70   GSM A-bis/OML: use more proto_tree_add_item() in dissect_oml_attrs()


Summary of changes:
 epan/dissectors/packet-gsm_abis_oml.c | 37 ++++++++++++++---------------------
 1 file changed, 15 insertions(+), 22 deletions(-)