Wireshark-commits: [Wireshark-commits] master 5b08742: GSM A-bis/OML: use generic proto_tree_add_it
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 20 Dec 2019 05:24:02 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5b08742905a2fe8e97f365202d78b17d3128569a
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

5b08742 by Vadim Yanitskiy (axilirator@xxxxxxxxx):

    GSM A-bis/OML: use generic proto_tree_add_item() for IPv4 addresses
    
    We never use a value returned by tvb_get_ipv4() for anything else
    than calling proto_tree_add_ipv4(). Thus we can simply call
    proto_tree_add_item(), and get rid of a temporary variable.
    
    Change-Id: Ifbabef0cf835df288bc6fad8d89ca739ad86f81c
    Reviewed-on: https://code.wireshark.org/review/35502
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  88364fb   GSM A-bis/OML: fix: do not use tvb_get_ntohl() to fetch IPv4 address
     add  5b08742   GSM A-bis/OML: use generic proto_tree_add_item() for IPv4 addresses


Summary of changes:
 epan/dissectors/packet-gsm_abis_oml.c | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)