Wireshark-commits: [Wireshark-commits] master-3.2 310506d: Qt: Don't crash when disabling all proto
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 18 Dec 2019 17:34:45 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=310506d7c1dddedd9a12d3cc80ad8df735bdaff9
Submitter: "Gerald Combs <gerald@xxxxxxxxxxxxx>"
Changed: branch: master-3.2
Repository: wireshark

Commits:

310506d by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Qt: Don't crash when disabling all protocols.
    
    Ensure that a protocol can be disabled before attempting to do so. Fixes
    crash described at
    https://ask.wireshark.org/question/13573/wireshark-crashes-in-the-enabled-protocols-dialog-box/
    
    Change-Id: Ib774bb6d636e82b79c5a922272a39126da85b71d
    Reviewed-on: https://code.wireshark.org/review/35489
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Reviewed-by: Pascal Quantin <pascal@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    (cherry picked from commit 5e5a87f45e652ec6c726292edd721da45101fd76)
    Reviewed-on: https://code.wireshark.org/review/35490
    

Actions performed:

    from  e4e823a   ieee802.11: Support the latest band id values and fix MHz.
     add  310506d   Qt: Don't crash when disabling all protocols.


Summary of changes:
 ui/qt/models/enabled_protocols_model.cpp | 3 +++
 1 file changed, 3 insertions(+)