Wireshark-commits: [Wireshark-commits] master b044c5f: Qt: Don't crash when disabling all protocols
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 18 Dec 2019 17:34:31 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b044c5f1de14dc7b8fb54d431f2a695aafe6669a
Submitter: "Gerald Combs <gerald@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

b044c5f by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Qt: Don't crash when disabling all protocols.
    
    Ensure that a protocol can be disabled before attempting to do so. Fixes
    crash described at
    https://ask.wireshark.org/question/13573/wireshark-crashes-in-the-enabled-protocols-dialog-box/
    
    Change-Id: Ib774bb6d636e82b79c5a922272a39126da85b71d
    Reviewed-on: https://code.wireshark.org/review/35489
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Reviewed-by: Pascal Quantin <pascal@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  a9c79f0   Uncrustify: Change line length to 100 chars
     add  b044c5f   Qt: Don't crash when disabling all protocols.


Summary of changes:
 ui/qt/models/enabled_protocols_model.cpp | 3 +++
 1 file changed, 3 insertions(+)