Wireshark-commits: [Wireshark-commits] master f6953e3: Qt: Remove a couple of private variables.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 28 Nov 2019 22:54:52 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f6953e378afe2a034b84d103052984570e740ed1
Submitter: "Peter Wu <peter@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

f6953e3 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Qt: Remove a couple of private variables.
    
    ByteViewText and ProtoTree only use mono_font_ in setMonospaceFont, so
    there's not much use in declaring it private in each case.
    
    Change-Id: I3ad986052f6e013988ce851420f7f6e7b47b7ea8
    Reviewed-on: https://code.wireshark.org/review/35255
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  40eece9   Change struct can_identifier to can_info
     add  f6953e3   Qt: Remove a couple of private variables.


Summary of changes:
 ui/qt/proto_tree.cpp             |  3 +--
 ui/qt/proto_tree.h               |  1 -
 ui/qt/widgets/byte_view_text.cpp | 12 ++++++------
 ui/qt/widgets/byte_view_text.h   |  3 +--
 4 files changed, 8 insertions(+), 11 deletions(-)