Wireshark-commits: [Wireshark-commits] master-3.2 9f8c487: Change struct can_identifier to can_info
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 28 Nov 2019 18:33:44 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9f8c487e69b6226ec0f7a8a37648b28aec012b65
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master-3.2
Repository: wireshark

Commits:

9f8c487 by Stefan Tatschner (stefan@xxxxxxxxxxxxxx):

    Change struct can_identifier to can_info
    
    The can specific data structure `struct can_identifier` is used as
    supplementary data for higher level dissectors. This patch adds more
    data to this struct and renames it accordingly to `struct can_info`.
    
    More supplementary data is needed in order to dissect iso15765
    correctly, since the header format depends on details on the underlying
    CAN protocol (CAN 2.0B vs CAN-FD).
    
    Change-Id: Id068cf38453f98b67a5ec470a22e7013548c5a14
    Reviewed-on: https://code.wireshark.org/review/35246
    Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 40eece98f8e6bc9a0a8f0961e43e95f538322aec)
    Reviewed-on: https://code.wireshark.org/review/35256
    

Actions performed:

    from  79863cf   TLS: support Facebook's TLS 1.3 draft 23 and 26 versions
     add  9f8c487   Change struct can_identifier to can_info


Summary of changes:
 epan/dissectors/packet-autosar-nm.c |  8 ++--
 epan/dissectors/packet-caneth.c     | 10 ++---
 epan/dissectors/packet-canopen.c    | 16 +++----
 epan/dissectors/packet-devicenet.c  | 50 ++++++++++-----------
 epan/dissectors/packet-ieee1722.c   | 16 +++----
 epan/dissectors/packet-iso15765.c   |  8 ++--
 epan/dissectors/packet-isobus.c     | 38 ++++++++--------
 epan/dissectors/packet-j1939.c      | 38 ++++++++--------
 epan/dissectors/packet-obd-ii.c     | 10 ++---
 epan/dissectors/packet-socketcan.c  | 90 ++++++++++++++++++-------------------
 epan/dissectors/packet-socketcan.h  |  6 ++-
 11 files changed, 146 insertions(+), 144 deletions(-)