Wireshark · Wireshark-commits: [Wireshark-commits] master 076334a: Qt: fix packet selection when modifiers are pressed

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=076334a70c553b9e535f85958b1039cdb231cee2
Submitter: "Roland Knall <rknall@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

076334a by Peter Wu (peter@xxxxxxxxxxxxx):

    Qt: fix packet selection when modifiers are pressed
    
    When the Conversation Shortcut (Ctrl-1) was pressed, the current packet
    suddenly became deselected. Similarly for Go to First Packet (Ctrl-Home)
    and Go To Next Packet (Ctrl-.).
    
    Changing the selection mode to ExtendedSelection has as side-effect that
    setCurrentIndex is affected by modifiers such as Ctrl and Shift. Since
    Ctrl acts as a toggle, the current selection becomes empty and no
    packets are selected. Fix this by explicitly requesting the selection to
    be replaced.
    
    Tested as follows:
    
     1. wireshark -r test/captures/dhcp.pcap
     2. Select packet 3.
     3. Press Ctrl-1, Ctrl-2. (Colors change, the packet remains selected.)
     4. Press Ctrl-Home, Ctrl-Down, Ctrl-.
     5. Observe that the packet details list is populated.
    
    Change-Id: I17f00e7fbc6e63ad52b6a0543fd850b473e506a2
    Fixes: v3.1.1rc0-762-gb3f240dbf8 ("Qt: Multiselection in PacketList")
    Reviewed-on: https://code.wireshark.org/review/35203
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    Reviewed-by: Roland Knall <rknall@xxxxxxxxx>
    

Actions performed:

    from  6433e12   Qt: Show all column types in context menu
     add  076334a   Qt: fix packet selection when modifiers are pressed


Summary of changes:
 ui/qt/packet_list.cpp | 22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)