Wireshark-commits: [Wireshark-commits] master-3.0 fcfbeb9: Qt: prevent inline completion from happe
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=fcfbeb9c17f15071cfb3811950247c93b6cbfa92
Submitter: "Peter Wu <peter@xxxxxxxxxxxxx>"
Changed: branch: master-3.0
Repository: wireshark
Commits:
fcfbeb9 by Peter Wu (peter@xxxxxxxxxxxxx):
Qt: prevent inline completion from happening for filters
Commit v3.1.0rc0-1170-ga854811c4a replaced the deprecated
`setAutoCompletion(false)` call by `setCompleter(0)`. However, the
former has as side-effect that it prevents setLineEdit from creating a
custom completer. setCompleter on the other hand had no effect since
there was no existing completer.
To fix the issue, remove the completer after it is set by setLineEdit.
This has no effect on the completer from CaptureFilterEdit and
DisplayFilterEdit instances since they override the completer from
QLineEdit. To avoid any confusion, SyntaxLineEdit::setCompleter (and
completer) should probably be renamed, these are not used by QComboBox
since it is not marked as virtual method.
Bug: 16132
Change-Id: Iad619122eddb43eb4963347982bf65dacd29629b
Fixes: v3.1.0rc0-1170-ga854811c4a ("Qt: fix more more Qt 5.13 deprecation warnings")
Reviewed-on: https://code.wireshark.org/review/35198
Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
Tested-by: Petri Dish Buildbot
Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
Reviewed-by: Roland Knall <rknall@xxxxxxxxx>
(cherry picked from commit de0d3628f6cb1ad9025d93a2bafe940a344ffd60)
Reviewed-on: https://code.wireshark.org/review/35212
Petri-Dish: Roland Knall <rknall@xxxxxxxxx>
Actions performed:
from d6a66ee Qt: fix crash on Next/Previous Packet in Conversation without selection
add fcfbeb9 Qt: prevent inline completion from happening for filters
Summary of changes:
ui/qt/widgets/capture_filter_combo.cpp | 9 +++++----
ui/qt/widgets/display_filter_combo.cpp | 9 +++++----
2 files changed, 10 insertions(+), 8 deletions(-)
