Wireshark · Wireshark-commits: [Wireshark-commits] master-3.0 91f1109: Qt: fix display filter completion with few recent entries

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=91f1109c389f94ca19f3ab93edab2b19e43fcd39
Submitter: "Peter Wu <peter@xxxxxxxxxxxxx>"
Changed: branch: master-3.0
Repository: wireshark

Commits:

91f1109 by Peter Wu (peter@xxxxxxxxxxxxx):

    Qt: fix display filter completion with few recent entries
    
    If 1) the recent filters menu has less than 10 entries and 2) the cursor
    position is not at the end of the filter, then completion would fail.
    Additionally, pressing Enter on filters with syntax errors would also
    end up being saved, unintentionally.
    
    Fix these by disabling automatic addition of entries by Qt.
    
    Change-Id: I612c6cb8f317beb5459919b5c65b837db6150d07
    Reviewed-on: https://code.wireshark.org/review/35150
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    (cherry picked from commit 27f96069325ce84c825252d9cdf35538e57ce8d0)
    Reviewed-on: https://code.wireshark.org/review/35197
    

Actions performed:

    from  0923edd   [Automatic update for 2019-11-24]
     add  91f1109   Qt: fix display filter completion with few recent entries


Summary of changes:
 ui/qt/widgets/display_filter_combo.cpp | 5 +++++
 1 file changed, 5 insertions(+)