Wireshark-commits: [Wireshark-commits] master-3.2 78940a2: Qt: fix display filter completion with f
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 24 Nov 2019 18:29:10 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=78940a2f58473b755c7b84d72d94b62002ec51c1
Submitter: "Peter Wu <peter@xxxxxxxxxxxxx>"
Changed: branch: master-3.2
Repository: wireshark

Commits:

78940a2 by Peter Wu (peter@xxxxxxxxxxxxx):

    Qt: fix display filter completion with few recent entries
    
    If 1) the recent filters menu has less than 10 entries and 2) the cursor
    position is not at the end of the filter, then completion would fail.
    Additionally, pressing Enter on filters with syntax errors would also
    end up being saved, unintentionally.
    
    Fix these by disabling automatic addition of entries by Qt.
    
    Change-Id: I612c6cb8f317beb5459919b5c65b837db6150d07
    Reviewed-on: https://code.wireshark.org/review/35150
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    (cherry picked from commit d15d8527736343f0dc40f969944744b5d4c0125d)
    Reviewed-on: https://code.wireshark.org/review/35196
    

Actions performed:

    from  42a0d7b   [Automatic update for 2019-11-24]
     add  78940a2   Qt: fix display filter completion with few recent entries


Summary of changes:
 ui/qt/widgets/display_filter_combo.cpp | 5 +++++
 1 file changed, 5 insertions(+)